chore: Delete old serialization methods #9951
Open
+949
−1,232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalladino
force-pushed
the
palla/serialization-clean-up
branch
from
8b37753
to
d5d0773
Compare
spalladino
force-pushed
the
palla/serialization-clean-up
branch
2 times, most recently
from
dd10486
to
1336c20
Compare
spalladino
force-pushed
the
palla/serialization-clean-up
branch
2 times, most recently
from
4638e70
to
6cdbe47
Compare
Cleans up several toJSON and fromJSON methods that are no longer needed since we moved to schemas. Also drops hex serialization for most complex entities, such as circuit inputs and outputs, and replaces it with base64.
spalladino
force-pushed
the
palla/serialization-clean-up
branch
from
6cdbe47
to
8e63e0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up several toJSON and fromJSON methods that are no longer needed since we moved to schemas. Also drops hex serialization for most complex entities, such as circuit inputs and outputs, and replaces it with base64.